[Freeciv-Dev] bug in gui-gtk/cityrep.c

[Andreas Kemnade <akemnade@xxxxxxxxxxx>]

Hi,
While porting the change all dialog to windows I found the following bug:

--- client/gui-gtk/cityrep.c~   Sun Apr  2 03:08:08 2000
+++ client/gui-gtk/cityrep.c    Tue Jan  2 21:47:21 2001
@@ -923,7 +923,7 @@
                j = gtk_clist_append(GTK_CLIST(city_change_all_from_list), buf);
                gtk_clist_set_row_data(GTK_CLIST(city_change_all_from_list),
                                       j, (gpointer)(i+B_LAST));
-               if (is_building[i] == 2) {
+               if (is_building[i+B_LAST] == 2) {
                    gtk_clist_select_row(GTK_CLIST(city_change_all_from_list),
                                          j, 0);
                }


It causes that if a city builds a unit, it won't be selected in the
from list.

Greetings
Andreas Kemnade
PS: I have not tested that piece of code, I just want to let you know.
The bug is present at least in 1.11.4 and in current cvs