Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2000:
[Freeciv-Dev] Re: pplayer->revolution
Home

[Freeciv-Dev] Re: pplayer->revolution

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Thue <thue@xxxxxxx>
Cc: <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: pplayer->revolution
From: Marko Lindqvist <caz@xxxxxxxxx>
Date: Tue, 26 Dec 2000 14:13:30 +0200 (EET)

On Tue, 26 Dec 2000, Thue wrote:

> There is lots of checks for
>   if((pplayer->revolution>5) || (pplayer->revolution<0))
> In the code, but as far as I can see pplayer->revolution can only be in that
> interval already. I grepped for occurences of revolution in the entire code
> and tried testing a bit, but I couldn't find any way it could get away. Does
> anyone have any words of wisdom, or should teh obsilete checks just be
> removed? (or replaced by a few asserts)
>
> -Thue

 Don't know about wisdom, but...

 Actually, there's related bugs when setting 'when_anarchy' to any
government type available otherwise. In order to fix this, I have to
change the way player.revolution works a bit.


 Caz

--




[Prev in Thread] Current Thread [Next in Thread]