[Freeciv-Dev] Re: pplayer->revolution

[Marko Lindqvist <caz@xxxxxxxxx>]

On Tue, 26 Dec 2000, Thue wrote:

> There is lots of checks for
>   if((pplayer->revolution>5) || (pplayer->revolution<0))
> In the code, but as far as I can see pplayer->revolution can only be in that
> interval already. I grepped for occurences of revolution in the entire code
> and tried testing a bit, but I couldn't find any way it could get away. Does
> anyone have any words of wisdom, or should teh obsilete checks just be
> removed? (or replaced by a few asserts)
>
> -Thue

 Don't know about wisdom, but...

 Actually, there's related bugs when setting 'when_anarchy' to any
government type available otherwise. In order to fix this, I have to
change the way player.revolution works a bit.


 Caz

--