Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2000:
[Freeciv-Dev] Re: Freeciv Patch: national ruleset can now grant specifie
Home

[Freeciv-Dev] Re: Freeciv Patch: national ruleset can now grant specifie

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Bobby D. Bryant" <bdbryant@xxxxxxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx
Cc: freeciv-data <freeciv-data@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: Freeciv Patch: national ruleset can now grant specified initial techs.
From: David Pfitzner <dwpfitzner@xxxxxxxxx>
Date: Tue, 26 Dec 2000 11:39:08 -0800 (PST)

"Bobby D. Bryant" <bdbryant@xxxxxxxxxxxxxxx> wrote: 

> The attached .diff allows a national ruleset to specify some techs to
> be granted to a nation at the start of the game.  (This feature is
> needed for various modpacks now under development.)

Looks good.  One minor implementation comment, and not really a
substantive one at that: 

Although its not actually wrong (AFAICS), I was discomforted by your 
changes in init_tech():  For every tech you iterate all initial techs 
to look for a match.  It would seem simpler to me to leave the loop 
which sets all techs to UNKNOWN, and then just iterate the initial 
techs once and set those not A_NONE to KNOWN.

-- David


__________________________________________________
Do You Yahoo!?
Yahoo! Shopping - Thousands of Stores. Millions of Products.
http://shopping.yahoo.com/



[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: Freeciv Patch: national ruleset can now grant specified initial techs., David Pfitzner <=