[Freeciv-Dev] Re: [PATCH] wonder notification

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/07/02 17:32 , Daniel Zinsli wrote:
>This patch adds a variable wondernotify that determines whether or not to
>inform players of wonders being started or stopped.

A couple of problem: 1. This new variable is not written to save files; 2.
It is never initialized.

See the implementation of civilwarsize (game.[hc], savegame.c, stdinhand.c)
for an example of a complete implementation.

>The default behaviour is to notify everyone when the computer starts or
>stops building, but not when a human player does.
>
>I _think_ this conforms to civ2:
>
>-I remember being notified when the computer civ's started/stopped
>building
>-I remember _not_ being notified when a human player did. (this adds lots
>more excitement at the start, not knowing which wonders the others are
>going for.)
>
>Could someone please verify this?

Civ 2 didn't have other human players.

I believe the following values for wondernotify may be better:

  0 = no notifications are sent
  1 = send notifications of AI players' changes
  2 = send notifications of Human players' changes
  3 = send notifications of *all* players' changes

(hey, a bit-mask!).  Also, perhaps, the default should be 3, to conform to
the existing code.

jjm