[Freeciv-Dev] Re: [PATCH] Renaming cities. (PR#567)

[Gaute B Strokkenes <gs234@xxxxxxxxx>]

Gaute B Strokkenes <gs234@xxxxxxxxx> writes:

> And we'd better do something about game_find_city_by_name().  As
> long as there is no bijection between cities and their names, it's a
> disaster just waiting to happen.  A better name would be
> game_exists_city_by_name(), returning a boolean value.

Lo and behold: I just found a bug.  In the xaw client at least, it
seems that the window with the list of cities that you can select and
then center on uses game_find_city_by_name() to find the city struct
(and hence the coordinates) of the city you selected.  The result is
that if there are two cities with the same name, which is currently
allowed, only the first one will ever be found.

It's only cosmetic, but it's still a bug.  I'd fix it myself, but the
GUI code is out of my area of competence, sorry.

-- 
Big Gaute (not to be confused with LG)
Hello...  IRON CURTAIN?  Send over a SAUSAGE PIZZA!
 World War III?  No thanks!