Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2000:
[Freeciv-Dev] [PATCH] Re: Short stupid question (PR#569)
Home

[Freeciv-Dev] [PATCH] Re: Short stupid question (PR#569)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Cc: bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] [PATCH] Re: Short stupid question (PR#569)
From: Gaute B Strokkenes <gs234@xxxxxxxxx>
Date: Sat, 23 Sep 2000 19:34:46 -0700 (PDT)

Erik Sigra <freeciv@xxxxxxx> writes:

> In server/mapgen.c:

> Is the use of "*hmap(x, y)" equivalent to the use of "full_map(x, y)"?

That's not at all a stupid question.  Answer: Yes (bet you're really
surprised now, eh? 8-) except that full_map() doesn't check if it
should normalise the x-coordinate, which I think is probably a bug
since there are lots of calls along the lines of full_map(x-1, y)
(well, not directly, but indirectly through e.g. make_dessert() etc.)

Here's a patch to clean up the mess:

Attachment: hmap_fix.diff
Description: Text Data

-- 
Big Gaute (not to be confused with LG)
Somewhere in Tenafly, New Jersey, a chiropractor is viewing
 ``Leave it to Beaver''!

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] [PATCH] Re: Short stupid question (PR#569), Gaute B Strokkenes <=