[Freeciv-Dev] Re: PATCH: po-file comment remove

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Dirk Stoecker <stoecker@xxxxxxxxxxxxxxxxxxxxxx> wrote:

> as the comments copied to po-files move around in the file
> with no real destination, they are a bit useless. Also I checked
> all the copied comments and 99% of them are programmer comments
> and not useful for translators. So here is a patch to
> po/Makefile.in.in, which removes comments copy and thus also useless
> comments from po-files. (removes argument --add-comments from xgettext
> call).

I don't think I like this.  Even though many of the included comments
are spurious, its useful to have the possibility of deliberately
adding comments intended for traslators.

(Maybe would be better if could "tag" coments intented for inclusion
in po files.  Also, part of problem is that xgettext includes the
comment immediately _before_ marking, whereas often its more natural
in the code to put to comment after, in which case it gets associated
with the wrong po-file entry.)

> Also added --escape to the arguments to convert the none-normal
> characters to escape characters. This affects some of the gui-mui
> strings, which use 0x1B escape character.

Are you sure this doesn't interfere with any translations, eg, I would
(ignorantly) suspect ja.po for starters?  (Just out of interest, what
are the escape characters for in gui-mui?)

-- David