[Freeciv-Dev] Re: indefinite improvements

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/08/21 09:07 , David Pfitzner wrote:
>Jeff Mallatt <jjm@xxxxxxxxxxxx> wrote:
>> 
>> I changed WORKLIST_END to 0xFFFF, and simply changed the save-file loader
>> to translate 284 to (the new) WORKLIST_END when loading old save-files
>> (discriminated by a new SAVEFILE_OPTION, "new_worklist_end").  The rest of
>> the code shouldn't have to change.

A new patch which addresses David's new comments...

>Hmm, shouldn't we also translate to/from 284 in the packet code, 
>for client/server combinations which disagree about the value 
>of WORKLIST_END?

Done.

>Also, I would prefer encoding WORKLIST_END as "-1" in the savefile
>(ie, use 0xFF elsewhere, but convert to/from -1 in the save/load 
>functions).  That would be shorter (pre-compression) and more 
>pleasant for humans inspecting the savefile, since tend to get 
>rows like:
>
>284,284,284,284,284,284,284,284,284,284,284,284,284,284,284,284
>
>compare:
>
>65535,65535,65535,65535,65535,65535,65535,65535,65535,65535,65535,65535,655
35,65535,65535,65535
>
>vs 
>
>-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1

Done.

indef-impr-9.diff.gz
Description: Binary data

jjm