[Freeciv-Dev] Re: [PATCH] Cleanup of common/shared.c and related files. (PR#500)

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/08/08 12:35 , Gaute (B) Strokkenes wrote:
>
>This patch fixes a minor 64bit bug (int_to_text ()) would break if
>ints are 64 bits,) adds a missing prototype, removes an obsolete
>define (WIPEBIT) and adds lots of comments.
>

A couple of things.  First, we prefer to not re-format code that isn't
being changed.  And, if we re-format, we prefer to conform to "indent -kr
-i2" (as specified on the web site and in the hackers guide).

Second, we're moving common code out of the individual GUIs, not into it.
Even simple code, like the motto string.

Also, while I was looking at the changes to get_sane_name(), I decided to
clean it up and make it slightly more restrictive: simply not allowing
names to begin or end with whitespace.

Attached is an updated patch.

shared_cleanup-4.diff
Description: Text document

jjm