Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2000:
[Freeciv-Dev] Re: patch: allow events at (0,0) (PR#480)
Home

[Freeciv-Dev] Re: patch: allow events at (0,0) (PR#480)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: David Pfitzner <dwp@xxxxxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx
Cc: bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: patch: allow events at (0,0) (PR#480)
From: Thue <thue@xxxxxxx>
Date: Thu, 27 Jul 2000 23:58:05 +0200

Den ons, 26 jul 2000 skrev David Pfitzner:
> 
> Currently, event notifications (not counting E_NOEVENT) are specified
> as having "no location" by specifying map coordinates (x,y) = (0,0).
> This is not good because (0,0) is a genuine location, and genuine
> events may occur there.
> 
> This patch changes to use (-1,-1) for "no location".  Actual test is 
> done as y inside or outside [0,map.ysize).  (This catches case that 
> (-1,-1) becomes (255,255) via unsigned packet code.)  Uses non-mandatory 
> capability tag "event00_fix" for backward compatability: new server sends 
> (0,0) to old clients, and new client converts (0,0) from old servers.
> 
> -- David
> 

I added a new event with no location in a commit; now the patch is updated
to also change that to -1, -1.

-Thue

Attachment: event00_fix2.diff
Description: Text Data


[Prev in Thread] Current Thread [Next in Thread]