[Freeciv-Dev] Re: Two patches

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/06/28 16:28 , Kero van Gelder wrote:
>First patchs improves the shuffle_players() to perfect randomness (it
>was close, but n! is not a perfect divisor of n^n), save the
>randomness of my_rand().

I don't understand this patch.  The new code seems to me to have the same
effect as the old code.

>Second patch moves a couple of unit strings derived in gui-gtk to
>common/unit.c (I'd like to change the information printed much more,
>but I'll wait with that until this patch is applied; also, I don't
>thin the function unit_description() is very helpful).
>
>In particular, the 'V' for veteran is added by
>unit_statistics_text(). Now I believe you're not supposed to see
>whether an _enemy_ unit is veteran or not, so I turned the field to
>false when the server passes unit info to a client that's not the
>owner of the unit.

This patch is missing the Xaw (and MUI, if possible) implementations.  I'll
get to them eventually, if no one else does.

jjm