[Freeciv-Dev] Re: readline completion

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Thue <thue@xxxxxxx> wrote:

> Completes function names, server option names, player names and filenames
> where appropriate.

Nice.  (Debian 2.1, readline 4.1).

Comments:

You don't need to write str_dub(), we already have mystrdup() 
in support.c?

You write:

+   If there were a command that could use completions from two of these
+   types (say, you could issue the command followed by either a filenames
+   or a player names) it would not currently be possible. But currently no
+   commands need this */

Actually there is: 'help' takes command names and option names 
(plus a few help-specific options).

There are also a few other odd-ball server options not covered,
not sure if it is worth doing so...  Eg, cmdlevel, rulesout...
'show' should be added to server_option_cmd[].

Not sure if it would be appropriate to integrate this more with 
the existing code (or change the existing code) which supports 
abbreviated arguments -- see optname_accessor(), helparg_accessor() 
etc.

-- David