[Freeciv-Dev] Re: 1/2 readline patch

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Jeff Mallatt wrote:
> At 2000/06/01 12:26 , Thue Janus Kristensen wrote:
> >I have tried making readline work with the civserver, but haven't been
> >completely succesfull.

> Here's another attempt.  It addresses the first two problems, and adds
> saving/reloading the history to a file (~/.civserver_history).  Also,
> rearranges configure stuff to be more consistent and automatic.

This configures fine (finds readline once I have the right packages
installed), and compiles, but then core dumps when I try to run!
(And sometimes leaves the terminal in a strange state, but
'stty sane' seems to fix.)

$ server/civserver 
This is the server for Freeciv version 1.11.1-devel
You can learn a lot about Freeciv at http://www.freeciv.org/
1: Now accepting new client connections.

For introductory help, type 'help'.
Segmentation fault (core dumped)

...
This GDB was configured as "i486-pc-linux-gnu"...
Core was generated by `./server/civserver'.
Program terminated with signal 11, Segmentation fault.
Reading symbols from /usr/lib/libz.so.1...done.
Reading symbols from /lib/libreadline.so.2...done.
Reading symbols from /lib/libc.so.6...done.
Reading symbols from /lib/libncurses.so.4...done.
Reading symbols from /lib/ld-linux.so.2...done.
#0  0x40098fd8 in   ()
(gdb) bt
#0  0x40098fd8 in   ()
#1  0x40037483 in rl_prep_terminal ()
#2  0x40044900 in rl_getc ()
#3  0x40044984 in rl_callback_handler_install ()
#4  0x808b3b3 in sniff_packets () at sernet.c:214
#5  0x8059155 in main (argc=1, argv=0xbffffac4) at civserver.c:336
#6  0x40069a42 in   ()
(gdb)

Tried Thue's original patch instead -- same result.

Debian (mainly slink/2.1) 
readline 2.1 (debian libreadlineg2_2.1-12 and libreadlineg2-dev_2.1-12)
(uses libncurses4 4.2-3)

strace ends with:

ioctl(0, TIOCGWINSZ, {ws_row=24, ws_col=80, ws_xpixel=579, ws_ypixel=340}) = 0
ioctl(0, TIOCSWINSZ, {ws_row=24, ws_col=80, ws_xpixel=579, ws_ypixel=340}) = 0
ioctl(0, TCGETS, {B9600 opost isig icanon echo ...}) = 0
brk(0x843f000)                          = 0x843f000
stat("/etc/inputrc", {st_mode=S_IFREG|0644, st_size=315, ...}) = 0
open("/etc/inputrc", O_RDONLY)          = 4
read(4, "# /etc/inputrc - global inputrc "..., 315) = 315
close(4)                                = 0
stat("/home/dwp/.inputrc", 0xbffff788)  = -1 ENOENT (No such file or directory)
SYS_175(0, 0x4004fca8, 0x4004fd28, 0x8, 0) = 0
ioctl(0, TIOCGWINSZ, {ws_row=24, ws_col=80, ws_xpixel=579, ws_ypixel=340}) = 0
ioctl(0, TIOCSWINSZ, {ws_row=24, ws_col=80, ws_xpixel=579, ws_ypixel=340}) = 0
ioctl(0, TCGETS, {B9600 opost isig icanon echo ...}) = 0
ioctl(0, SNDCTL_TMR_STOP, {B9600 opost isig -icanon -echo ...}) = 0
--- SIGSEGV (Segmentation fault) ---
+++ killed by SIGSEGV +++

Same result on xterm, rxvt, linux console...
Backing out zlib patch didn't help (long shot).

?

I could try upgrading the packages involved to latest versions, 
but haven't yet.

-- David