[Freeciv-Dev] city and unit visibility

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

This patch fixes a few small problems with city and unit visibility.  It
also does a little clean-up.

The city visibility problem is that when the focus unit is in a city, and
its icon is flashing, when the unit icon was seen, _nothing_ of the city
was -and- when the unit icon was not seen, the city's "occupied" flag was
not shown.

With this patch, the city is always fully displayed "under" the flashing
unit icon.

The unit visibility problem is one that was introduced since 1.10.0
(though, I don't know exactly when).  When a unit is defending a city, the
attacker should see the unit.  Currently, the attacker only sees the city.

With this patch, the defending unit is visible to the attacker.
Implementing this actually cleaned up some code.

city-unit-visibility-1.diff
Description: Text document

jjm