[Freeciv-Dev] bug x 2 (PR#333)

[Tuomas Airaksinen <tuma@xxxxxxxxxxxx>]

Two bugs:

Civserver (cvs 8.4.) crash while completing the first savegame in that game. 

...
1: Map generator: not enough start positions, fixing.
1: last message repeated 2 times
1: last message repeated 2 times (total 4 repeats)
1: last message repeated 4 times (total 8 repeats)
1: last message repeated 8 times (total 16 repeats)
1: last message repeated 4 times (total 20 repeats)
1: The map has 24 starting positions on 6 isles.
> save /tuma/civ/tuma8.4.2k.sav
Segmentation fault (core dumped)
[tuma@paaskyniemi civ]$ gdb ../download/freeciv_build/server/civserver core
GNU gdb 19991004
Copyright 1998 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i386-redhat-linux"...
Core was generated by `../download/freeciv_build/server/civserver'.
Program terminated with signal 11, Segmentation fault.
Reading symbols from /lib/libc.so.6...done.
Reading symbols from /lib/ld-linux.so.2...done.
Reading symbols from /lib/libnss_files.so.2...done.
#0  0x80677db in player_save (plr=0x821faf4, plrno=0, file=0xbfffd678) at 
plrhand.c:2746
2746                secfile_insert_int(file, pdcity->id, "player%d.dc%d.id", 
plrno, i);
(gdb) bt
#0  0x80677db in player_save (plr=0x821faf4, plrno=0, file=0xbfffd678) at 
plrhand.c:2746
#1  0x8057e8b in game_save (file=0xbfffd678) at gamehand.c:665
#2  0x8053016 in save_game (filename=0xbfffd6cc "/tuma/civ/tuma8.4.2k.sav") at 
civserver.c:848
#3  0x807211c in save_command (caller=0x0, arg=0xbfffd6cc 
"/tuma/civ/tuma8.4.2k.sav") at stdinhand.c:1350
#4  0x8074dbf in handle_stdin_input (caller=0x0, str=0xbffff71c "save 
/tuma/civ/tuma8.4.2k.sav\n")
    at stdinhand.c:2249
#5  0x806c6a5 in sniff_packets () at sernet.c:196
#6  0x8052655 in main (argc=1, argv=0xbffffa44) at civserver.c:492              
                                   

Civserver crash while starting a new game:

[tuma@paaskyniemi civ]$ gdb ../download/freeciv_build/server/civserver core
GNU gdb 19991004
Copyright 1998 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i386-redhat-linux"...
Core was generated by `../download/freeciv_build/server/civserver -r 
./tumanscripti'.
Program terminated with signal 11, Segmentation fault.
Reading symbols from /lib/libc.so.6...done.
Reading symbols from /lib/ld-linux.so.2...done.
Reading symbols from /lib/libnss_files.so.2...done.
#0  package_dumb_city (pplayer=0x8228314, x=1, y=50, packet=0xbffff7b4) at 
cityhand.c:980
980       packet->id=pdcity->id;
(gdb) bt
#0  package_dumb_city (pplayer=0x8228314, x=1, y=50, packet=0xbffff7b4) at 
cityhand.c:980
#1  0x804ba3a in send_city_info_at_tile (dest=0x8228314, x=1, y=50) at 
cityhand.c:770
#2  0x804c4a9 in send_all_known_cities (dest=0x0) at cityhand.c:1117
#3  0x8052bab in send_all_info (dest=0x0) at civserver.c:669
#4  0x80525d1 in main (argc=3, argv=0xbffffa34) at civserver.c:464

This can be repeated with following script:

create comp
set ysize 80
normal
(then client connects and...)
start 
(client selects his nation)
crash!

--
kirjoitti:  Tuomas Airaksinen              linux
kotisivu:   http://tumasites.cjb.net        is
sähköposti: tuma@xxxxxxxxxxxx                all we
icq:        11870110, ircnet: tuma            need