[Freeciv-Dev] Re: [FreeCiv-Cvs] jjm: Fixes city_turns_to_build() to consider the 1 s...

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/01/29 09:18 , Andrew McGuinness wrote:
>freeciv@xxxxxxxxxxxxxxxxxxx writes:
> > This is an automated notification of a change to freeciv cvs, 
> > on Sat Jan 29 04:40:18 PST 2000 = Sat Jan 29 12:40:18 2000 (GMT)
> > by Jeff Mallatt <jjm@xxxxxxxxxxxx>
> > 
> > ---- Files affected:
> > 
> > freeciv/client/gui-mui citydlg.c
> > freeciv/common city.c
> > 
> > ---- Log message:
> > 
> > Fixes city_turns_to_build() to consider the 1 shield given to cities that
> > are not in disorder, but have a zero shield surplus.  Removes duplicate
> > city_turns_to_build() from gui-mui code.
> > Addresses PR#238.
> > Patch submitted by Mike Jing <miky40@xxxxxxxxxxx>.
> > 
>
>Is this really right?  I'm pretty sure that in CivII, if a city has
>a surplus of zero, it doesn't build anything.  The CivII "turns to
>build" acts as if it does, but I assume that's just it's way of
>avoiding divide by zero.

You are correct.  Neither Civ1 nor Civ2 give this "extra" shield.

jjm