[Freeciv-Dev] SIG_PIPE (was: Compiler Problem in astring.c)

[sebauer@xxxxxxxxxxx (Sebastian Bauer)]

Hello David

>> Also my system doesn't know about SIGPIPE. I've put
>> #ifdef SIGPIPE and #endif pair around the signal function in
>> sernet.c.
> Hmm, but is this correct?  That is, is SIGPIPE guaranteed
> to be testable with #ifdef SIGPIPE, or could it be an enum
> or something, which would fail #ifdef SIGPIPE even if
> SIG_PIPE really was there?
> (Though #ifdef SIGPIPE does seem to work on some systems
> I've tried just now.)
> (If necessary an alternative would be to write an appropriate
> configure check.)

No idea. I saw in glib/gstrfuncs.c that they also used
#ifdef SIGPIPE.
But anywhy I wrote a patch for configure. I hope everything is
Ok (I'm not familiar with this)...

>> Maybe it is also possible to remove the ATHING_INIT marcro
>> and use ath_init() instead (although the are no further problems)?
> Agreed.  Well, ATHING_INIT could still be used where it's _known_
> that size is constant (eg sizeof?) but to avoid future accidents
> using gcc it's not too much of a problem to remove it.

Yes, I think like you ;-)

>> If you agree I will write the patch for it.
> Well, I've done this already :-)

Great :-)

bye,
Sebastian Bauer

sigpipe.diff
Description: Text document