[Freeciv-Dev] bug: server sends enemy cities information (PR#80)

[pejean.lists@xxxxxxxxx]

This is a multi-part message in MIME format.
--------------CAB04BA46C725D9B1F66B417
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

I found that the server sends information about enemy cities
if the client requests it. The patch attached to this message
demonstrates that. It allows the player to get from the server
all the information about any city he can see. With it, just
click on an enemy city to open a city dialog.

This uses the gtk client and the server of the latest cvs.
--------------CAB04BA46C725D9B1F66B417
Content-Type: text/plain; charset=us-ascii;
 name="freeciv.diff-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="freeciv.diff-1"

Index: client/gui-gtk/citydlg.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/citydlg.c,v
retrieving revision 1.16
diff -u -r1.16 citydlg.c
--- citydlg.c   1999/07/20 11:50:02     1.16
+++ citydlg.c   1999/07/29 01:40:32
@@ -195,7 +195,7 @@
                        ?TRUE:FALSE);
     gtk_widget_set_sensitive(pdialog->cityopt_command, TRUE);
   }
-  if(pcity->owner == game.player_idx)  {
+  if(TRUE)  {
     city_report_dialog_update_city(pcity);
     trade_report_dialog_update();
   } else {
Index: client/gui-gtk/mapctrl.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/mapctrl.c,v
retrieving revision 1.9
diff -u -r1.9 mapctrl.c
--- mapctrl.c   1999/07/24 03:22:52     1.9
+++ mapctrl.c   1999/07/29 01:40:36
@@ -928,7 +928,7 @@
     return TRUE;
   }
 
-  if(pcity && (event->button==1) && (game.player_idx==pcity->owner)) {
+  if(pcity && (event->button==1) && (TRUE)) {
     popup_city_dialog(pcity, 0);
     return TRUE;
   }



--------------CAB04BA46C725D9B1F66B417--