[Freeciv-Dev] City info is send twice during creation

[Artur Biesiadowski <abies@xxxxxxxxx>]

Server sends data about city two times - first impliciltly inside
auto_arrange_workers second time explicite by send_city_info. Both
packets happen to be the same (at least in cases I have seen), but I
wonder if this could lead to some subtle bug in future
(auto_arrange_workers depending on some not-yet initialized data).

So just for memory, that such problem exists (maybe it should go to
jitterbug as non-fatal bug, or maybe bug ?)

Backtraces included

Artur

----------

#0  send_packet_city_info (pc=0x80b6b40, req=0xbffff73c) at
packets.c:1097
#1  0x804a71a in send_city_info (dest=0x820d784, pcity=0x8228f08,
dosend=1)
    at cityhand.c:641
#2  0x804d7e1 in auto_arrange_workers (pcity=0x8228f08) at
cityturn.c:693
#3  0x8049a27 in create_city (pplayer=0x820d784, x=5, y=5,
    name=0x809f780 "Washington") at cityhand.c:159
#4  0x8069d0b in handle_unit_build_city (pplayer=0x820d784,
req=0x8228ed0)
    at unithand.c:435
#5  0x80505f7 in handle_packet_input (pconn=0x80b6b40, packet=0x8228ed0
"f",
    type=27) at civserver.c:958
#6  0x805f72d in sniff_packets () at sernet.c:165
#7  0x804f90d in main (argc=1, argv=0xbffffca4) at civserver.c:458
#8  0x4002fcb3 in __libc_start_main (main=0x804ee20 <main>, argc=1,
    argv=0xbffffca4, init=0x8048bb4 <_init>, fini=0x8085fec <_fini>,
    rtld_fini=0x4000a350 <_dl_fini>, stack_end=0xbffffc9c)
    at ../sysdeps/generic/libc-start.c:78 
    
    
#0  send_packet_city_info (pc=0x80b6b40, req=0xbffff770) at
packets.c:1097
#1  0x804a71a in send_city_info (dest=0x0, pcity=0x8228f08, dosend=0)
    at cityhand.c:641
#2  0x8049a57 in create_city (pplayer=0x820d784, x=5, y=5,
    name=0x809f780 "Washington") at cityhand.c:172
#3  0x8069d0b in handle_unit_build_city (pplayer=0x820d784,
req=0x8228ed0)
    at unithand.c:435
#4  0x80505f7 in handle_packet_input (pconn=0x80b6b40, packet=0x8228ed0
"f",
    type=27) at civserver.c:958
#5  0x805f72d in sniff_packets () at sernet.c:165
#6  0x804f90d in main (argc=1, argv=0xbffffca4) at civserver.c:458
#7  0x4002fcb3 in __libc_start_main (main=0x804ee20 <main>, argc=1,
    argv=0xbffffca4, init=0x8048bb4 <_init>, fini=0x8085fec <_fini>,
    rtld_fini=0x4000a350 <_dl_fini>, stack_end=0xbffffc9c)
    at ../sysdeps/generic/libc-start.c:78