Complete.Org: Mailing Lists: Archives: freeciv-dev: July 1999:
Re: [Freeciv-Dev] Patch adds trade info to GTK display. (PR#42)
Home

Re: [Freeciv-Dev] Patch adds trade info to GTK display. (PR#42)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: Re: [Freeciv-Dev] Patch adds trade info to GTK display. (PR#42)
From: Daniel Sjolie <deepone@xxxxxxxxxx>
Date: Sun, 11 Jul 1999 14:31:09 +0200

On 1999-07-11 22:24:12, David Pfitzner wrote:
> Bobby D. Bryant wrote:
> 
> > This is a patch to client/gui-gtk/citydlg.c.  It splits up the 
> > "Trade:" info in the panel at the left of the city display, 
> > separating out the amounts recieved from the city's various sources.
> 
> Are there any opinions on whether this patch is a good thing?
> 
> (I had trouble applying it due to some line wraps; I applied
> it by hand and have redone the diff and attached it, if that
> helps anyone try it out.)
> 
> Maybe its just that I don't use trade routes very much, but 
> I'm actually not that keen on the patch.  It seems to me that 
> it make the display (currently a nice simple column of tags and 
> numbers) more complicated and cluttered, when the information it 
> adds is not used that much.  With 30x30 tiles it also make the 
> city dialog bigger (vertically) if you do have a few trade routes.
> 
> On the other hand, if this were made a client option (defaulting
> to on or off, I don't care), I would be happy.  And it would
> seem relatively easy to do that.

Yes, please make it an option...
I think it should default to off... :)

/Daniel

[Prev in Thread] Current Thread [Next in Thread]