[Freeciv-Dev] [patch] struct government

[Sune Kirkeby <sune@xxxxxxxxxxxxx>]

Here is the latest incarnation of my struct government
monster-patch.  It removes enum government_type and replaces
all uses of G_* enums with fields in struct government.

The patch includes new AI code that tries to evalute
governments, and select the best one.  This code still needs
tweaking, and it knows nothing of general tactics (are we
at war, do we want to expand, etc).

TODO:
o The government names are still hardcoded in the Xaw client,
  and it expects there to be _exactly_ 6 governments.
o Update to latest CVS snapshot.
o Implement the features needed for fundamentalism:
  - Units that require a government to be built, and have special
    upkeep values under that government. (Fanatics).
  - NO_UNHAPPY_CITIZENS flag for governments.
  - CONVERT_TITHES_TO_MONEY flag for governments (surplus only?).
  - A research penalty that is applied after all other modifiers.
  - A diplomatic penalty modifier when international incidents occur.
    (Spy places nuke in city, goes to war, etc).
o Test the new government evaluation code (AI).

Sune

P.S. It depends on the unit upkeep patch and it was made
against a rather out-dated CVS snapshot.

-- 
Imagine, if you will, that there were no such thing as a hypothetical
situation...