Re: [Freeciv-Dev] Spies and Diplomats don't do stuff (PR#37)

[dwp@xxxxxxxxxxxxxx]

Mark Nettle wrote:

> Spies and diplomats need to be moved to enemy cities with the keyboard,
> rather than the mouse. This should probably be added to the FAQ. (Well
> actually, it should be fixed, but in the meantime ...)

I think this is actually rather complicated to do a proper fix.
A possible fix may include:

- Add an extra packet, for the server to be able to tell 
  the client it needs to popup a diplomat dialog (and where).
- In server/unithand.c:handle_unit_move_request(), check
  conditions and send above packet when appropriate
  (goto stuff will call handle_unit_move_request()).
- In client, add code to accept this packet.  Importantly,
  because there is currently only one global diplomat dialog,
  must also either generalize to allow multiple diplomat 
  dialogs (like multiple city dialogs etc), or have a 
  "queue", as for caravans (eg see process_caravan_arrival() 
  in client/gui-xaw/dialogs.c)
- And of course protect this with capabilities to not
  send new packet to old clients.

For now, I vote for just adding to the FAQ :-)

Regards,
-- David