[freeciv-dev] Erroneous monetary calculations?

["Bobby D. Bryant" <bdbryant@xxxxxxxxxxxxxxx>]

I'm wondering whether the bonuses for Bank, Marketplace, etc., are being
applied correctly.  It looks like the algorithim does something like
this:

    sum income from city and trade
    deduct corruption
    split remnant into tax/luxuries/research
    apply bonuses to tax only

I would have expected it to go like this:

    sum income from city and trade
    apply bonuses to the sum
    deduct corruption
    split remnant into tax/luxuries/research

or perhaps swap the order of corruption and bonuses (if it even makes a
difference) -- but surely the bonuses should apply before the split,
because the things that give the bonuses presumably make the whole
society more prosperous, and thus should help with luxuries and research
as well as with taxes.

Bobby Bryant
Austin, Texas