Re: [Freeciv-Dev] patch: caravan improvements

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

David Pfitzner wrote:

>  (Minor bug if more than one caravan
> in the boat though, since client expects only one caravan
> popup at a time so has only one set of data...)

Actually, this is a problem.  Also if more than one goto-ing
caravan arrives at end/begin-turn, all but one of the caravan
popups will be broken.

Could have a genlist of data for current caravan popups in
the client.  Could still have minor problem that button 
availability may become out of date, eg "build wonder" might 
later not apply, due to finishing wonder with action of a 
previous caravan.  

Hmm, this might work: have a list of data for pending caravan 
actions, and when caravan dialog is dealt with, check if there
is another one (and if still applicable), and if so do another
popup.  And so on with that popup.

(Another minor bug in the patch is that the call to popup
the caravan dialog should be protected by checking if the
player is AI or has options to see popups in AI mode.)

-- David