[Freeciv-Dev] Bug: can't build Hoover Dam on river

[Patrick Smith <patsmith@xxxxxxxxx>]

The help information for the Hoover Dam says it "can only be built in a
city
which is next to (or on) a Mountain or River tile".

But in fact the code only allows you to build it on a city which is next
to
such a tile; the tile the city itself is on is irrelevant.

So, for example, if you have a city built on a river tile, but with no
neighbouring river or mountain tiles, then you can't build the Hoover
Dam
there.

The function could_build_improvement (in common/city.c) calls
is_terrain_near_tile to check whether the city is near the appropriate
terrain.  But is_terrain_near_tile (in common/map.c) only checks the
tiles
around the tile it is given, and does not check the central tile itself.
-- 
patsmith@xxxxxxxxx