Re: [Freeciv-Dev] new kludge cleanup patch

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Trent Piepho wrote:
> 
> Why not move the city_id code to common as it is now.  Add a line to
> find_city_by_id(), that checks for citycachesize!=0. 

Yeah, that would be a better solution, and looks ok to me.

Note that the dealloc_id() kludge is separate, but could be
fixed by doing similar with the used_ids array and related 
functions in civserver.c

(Though it would seem to me that it _shouldn't_ be separate, and
that these two areas should be able to be merged.  But that would 
require more extensive work.)

-- David