[freeciv-data] Re: [Freeciv-Dev] Freeciv Patch: national ruleset can now
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
"Bobby D. Bryant" <bdbryant@xxxxxxxxxxxxxxx> wrote:
> The attached .diff allows a national ruleset to specify some techs to
> be granted to a nation at the start of the game. (This feature is
> needed for various modpacks now under development.)
Looks good. One minor implementation comment, and not really a
substantive one at that:
Although its not actually wrong (AFAICS), I was discomforted by your
changes in init_tech(): For every tech you iterate all initial techs
to look for a match. It would seem simpler to me to leave the loop
which sets all techs to UNKNOWN, and then just iterate the initial
techs once and set those not A_NONE to KNOWN.
Do You Yahoo!?
Yahoo! Shopping - Thousands of Stores. Millions of Products.
|[Prev in Thread]
||[Next in Thread]|
- [freeciv-data] Re: [Freeciv-Dev] Freeciv Patch: national ruleset can now grant specified initial techs.,
David Pfitzner <=