[freeciv-ai] (PR#9480) Patch: make CM aware of rapturesize

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=9480 >

> [bhudson - Fri Apr 22 04:37:28 2005]:
> 
> > [bhudson - Mon Aug 02 22:50:42 2004]:
> > We could do this trivially if we do a rules change.  Currently, a
> city
> > that has size 2 can be "happy"; which means that a city that grows
> to
> > size 3 can be in rapture immediately.  If we change city_happy to
> include
> >   pcity->size >= get_gov_pcity(pcity)->rapture_size
> > then a city that grows to size 3 has to wait a turn to be in
> rapture.
> >
> > I think the new behaviour is how it was in civ2, but I can't
> remember
> > exactly.
> 
> This is still an issue (and the patch still applies!); how do we feel
> about it?

The patch seems good to me.  Per's government-effects patch (12757)
touches this same code (or should) and kindof breaks or changes this
behavior (I don't fully understand how though; you'd have to ask
Genevieve or Per).  I'd say we can commit this patch first though.

In general, I don't fully understand how happiness, celebration,
unhappiness, and disorder work.  I know I've said this before, but: is
there some documentation on this that anyone can point me to?  If not,
can someone write some?  It's probably best to put it in the comment for
city_celebrating() and reference it in all the other such functions
(city_happy, etc.), but it would be okay in doc/README.* as well.

-jason