[freeciv-ai] Re: Fix ferry buglet and improve logging

[Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxxx>]

On Fri, 11 Jun 2004, Per Inge Mathisen wrote:

> This patch improves ferry logging and removes a small buglet - we didn't
> reset our goto coordinates or AI role when going idle from lack of task in
> ferry management code.

The patch is good and it made me think...
This passing control to of ferry to military code
 2519:   if (IS_ATTACKER(punit) && punit->moves_left > 0) {
 2520:      /* AI used to build frigates to attack and then use them as ferries
 2521:       * -- Syela */
 2522:      ai_manage_military(pplayer, punit);
 2523:      return;
 2524:   }
might be the culprit of lousy ferries reported by Jason: e.g. Caravel has
non-zero attack and will never be used as a ferry!!