Complete.Org: Mailing Lists: Archives: freeciv-ai: April 2004:
[freeciv-ai] Re: more aggressive bodyguards
Home

[freeciv-ai] Re: more aggressive bodyguards

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Per I. Mathisen" <per@xxxxxxxxxxx>
Cc: freeciv-ai@xxxxxxxxxxx
Subject: [freeciv-ai] Re: more aggressive bodyguards
From: Benoit Hudson <bh@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 29 Apr 2004 20:38:25 -0400

On Thu, Apr 29, 2004 at 07:44:27PM +0000, Per I. Mathisen wrote:
> -  } else {
> -    /* I had these guys set to just fortify, which is so dumb. -- Syela
> -     * Instead we can attack adjacent units and maybe even pick up some free 
> -     * cities! */
> -    (void) ai_military_rampage(punit, 40 * SHIELD_WEIGHTING, 
> -                               RAMPAGE_FREE_CITY_OR_BETTER);
>    }
> +  /* I had these guys set to just fortify, which is so dumb. -- Syela
> +   * Instead we can attack adjacent units and maybe even pick up some free 
> +   * cities! */
> +  (void) ai_military_rampage(punit, SHIELD_WEIGHTING * 4, /* WAG */
> +                             RAMPAGE_FREE_CITY_OR_BETTER);
>  }

Shouldn't "4" be a constant (40 should have been, too)?  This is the
perfect opportunity to remove a WAG literal constant.

        -- Benoît


[Prev in Thread] Current Thread [Next in Thread]