[freeciv-ai] Re: AI Diplomacy 10

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Fri, 20 Jun 2003, Jordi Negrevernis i Font wrote:
>   I manage to compile and play with AIDiplomacy10.diff.

Please let me know what you think about it :-)

>   Now, when i want to load the attached savegame it says:
...
> 1: Illegal alliance structure detected: Vojislav's alliance to Jaume I
> reduced to peace treaty.
...
> civserver: sanitycheck.c:240: check_units: Assertion
> `pplayers_allied(city_owner(pcity), pplayer)' failed.
> Abortado
>
> I didn't look at the code, but maybe this is because it checks the
> alliances against dead players?

Dead players don't per definition have units in cities, so no, I don't
think so.

> And if you break the alliance, some units may rest in non-allied cities...

This sounds likely to be the problem, yes. We should run resolve stacks
after breaking up an alliance. I guess we don't in savegame.c. I'll make a
patch ASAP if this is indeed the case.

  - Per