Complete.Org: Mailing Lists: Archives: freeciv-ai: May 2003:
[freeciv-ai] FIX is_stack_vulnerable

[freeciv-ai] FIX is_stack_vulnerable

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-fix <rt@xxxxxxxxxxxxxx>, freeciv-ai <freeciv-ai@xxxxxxxxxxx>
Subject: [freeciv-ai] FIX is_stack_vulnerable
From: Olivier DAVY <olivier.davy@xxxxxxx>
Date: Tue, 06 May 2003 09:35:13 +0200 (CEST)

Olivier DAVY

Here is a patch that cleans some code about is_stack_vulnerable, according to 
Gregory ideas.
As it is the second time I write a patch, fell free to send me comments about 


Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx> : 
I would recommend the following patch: do use is_stack_vulnerable like you 
did in your patch.  Move is_stack_vulnerable all the way to common/ (I 
think combat.c is the best place).  Use is_stack_vulnerable in the server 
as well (there is one place somewhere in unittools or unithand, do a 
grep).  And make no other changes in this patch.  Such a compact patch 
with clear-cut scope will be reviewed and commited much faster.

Best wishes,

 Olivier DAVY
 ENSIMAG engineer - HEC alumnus
 E-mail : olivier.davy@xxxxxxx
 Phone  : +33/(0)

Attachment: fix-is_stack_vulnerable-20030505-odavy.diff
Description: Text document

[Prev in Thread] Current Thread [Next in Thread]
  • [freeciv-ai] FIX is_stack_vulnerable, Olivier DAVY <=