[freeciv-ai] Re: (PR#3619) coordinate fix in find_city_to_diplomat

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Gregory Berkolaiko wrote:
> On Wed, 5 Mar 2003, Per I. Mathisen wrote:
> 
> 
>>On Wed, 5 Mar 2003, Jason Short wrote:
>>
>>>In find_city_to_diplomat, there is an initializer:
>>>
>>>int best_dist = MAX(map.xsize, map.ysize);
>>>
>>>this is no good under gen-topologies, because it is possible for a
>>>distance to be larger than this (map.xsize and map.ysize are the
>>>_native_ dimensions of the map, while the distance is in _map_ coordinates).
>>
>>It is also possible that the actual path to a distance is way longer than
>>this. It is only a WAG (wild ass guess) number to limit things in a
>>relatively sane way.
>>
>>There is no need to fix it for gen topol. Maybe for other reasons, though.
> 
> 
> I deeply suspect it will be gone when PF comes.

"XXX will be obsoleted by mega-patch YYY" is an argument we all use, and 
I don't think it's a good one.  If there's a bugfix or feature that can 
be done now, it shouldn't have to wait.

In this case, there's nothing really broken so waiting for PF is fine.

jason