Complete.Org: Mailing Lists: Archives: freeciv-ai: December 2002:
[freeciv-ai] Re: hp recovery patch

[freeciv-ai] Re: hp recovery patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Per I. Mathisen" <per@xxxxxxxxxxx>
Cc: freeciv-ai@xxxxxxxxxxx
Subject: [freeciv-ai] Re: hp recovery patch
From: Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Wed, 4 Dec 2002 22:32:28 +0000 (GMT)

The patch is generally quitr good although I haven't tested it yet: still 
checking out my first version of civ via cvs.  Comments:

1. The factor of 0.5 for the ill/healthy unit checkup deserves a define.
2. Usage of ai_rampage with these constants is outrageous.
3. Please use HPRECOVERY_LOGLEVEL (orwhatever it is called) for all 
freelogs related to HP recovery.

Still checking out these huge .po files that I will never ever use 


On Wed, 4 Dec 2002, Per I. Mathisen wrote:

> On Wed, 4 Dec 2002, Mike Kaufman wrote:
> > I would prefer that changes like this not be made since they would have to
> > be redone almost in their entirely for general effects. I would suggest
> > combining these two functions
> Ok, then I suggest the attached patch is committed instead, which should
> play nice to general effects.
> Thanks for suggesting this, the code is much better now.
> On Wed, 4 Dec 2002, Mike Kaufman wrote:
> > oh, and I would like the function to be called:
> >
> > select_nearest_recovery...() instead of find_...
> >
> > as the find_ version tends to make you think we're returning the location
> > rather than putting that location into goto_dest...
> Well, I changed that in the patch... so now it returns the best pcity.
>   - Per

[Prev in Thread] Current Thread [Next in Thread]