Complete.Org: Mailing Lists: Archives: freeciv-ai: September 2002:
[freeciv-ai] Re: enemies_at() flip flop
Home

[freeciv-ai] Re: enemies_at() flip flop

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Per I. Mathisen" <per@xxxxxxxxxxx>
Cc: freeciv-ai@xxxxxxxxxxx
Subject: [freeciv-ai] Re: enemies_at() flip flop
From: Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Wed, 25 Sep 2002 19:59:31 +0100 (BST)

On Wed, 25 Sep 2002, Per I. Mathisen wrote:

> On Wed, 25 Sep 2002, Gregory Berkolaiko wrote:
> > which file/function are you looking at?
> 
> server/unittols.c:enemies_at()

Of course, so says the subject, sorry :((

Yes, I agree with you completely.  No reason to be specially afraid of 
cities, we check them for dangerous items anyway.  A proposition at the 
patch is attached.  I also changed it to use handicaps and sprinkled 
liberally with comments.

However the arithmetic looks _very_ dubious to me.  You can either check 
it, or leave it for now.  I feel a strong urge to make calls to 
unit_vulnerability and belligerence more systematic and user friendly 
throughout the code.

G.

Attachment: enemies_at.diff
Description: Text document


[Prev in Thread] Current Thread [Next in Thread]