Complete.Org: Mailing Lists: Archives: offlineimap: July 2009:
[PATCH] Re: furbished dynamic ui plugin selection

[PATCH] Re: furbished dynamic ui plugin selection

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Christoph Höger <choeger@xxxxxxxxxxxxxxx>
Cc: Loui Chang <>, offlineimap@xxxxxxxxxxxx, Nicolas Sebrecht <nicolas.s-dev@xxxxxxxxxxx>
Subject: [PATCH] Re: furbished dynamic ui plugin selection
From: Nicolas Sebrecht <nicolas.s-dev@xxxxxxxxxxx>
Date: Mon, 27 Jul 2009 22:40:52 +0200

On Mon, Jul 27, 2009 at 08:07:13PM +0200, Christoph Höger wrote:
> Am Montag, den 27.07.2009, 12:34 -0400 schrieb Loui Chang:
> > On Sun 26 Jul 2009 11:46 +0200, Christoph H??ger wrote:
> >
> > > -#    This program is free software; you can redistribute it and/or modif=
> > > y
> > > -#    it under the terms of the GNU General Public License as published b=
> > > y
> > 
> > Looks like your patch is corrupt because long lines are broken. I'm not
> > sure what the cause might be, but consider using `git send-email` for
> > your patches.
> That is odd. The mail in my Sent folder looks perfect. I do not know
> what causes those line breaks. Maybe the list manager?

I notice this problem since your switch from Evolution to Mutt. It's
really like mutt is wrapping the long lines. Mutt can "decode" emails
before displaying them to the screen which may make the checks lying...
On top of that, I suspect mutt to wrap long lines /after/ saving the mail
to the "Sent" folder.

> John, could you apply the patch at all?

This is usually a bad idea because there are a lot of wrapped lines to
fix manually (with potential errors). Also, it doesn't encourage people
here to read/test the patch.

I agree with Loui Chang, could you please consider to use `git
send-email`? It does a good job and prevent from that kind of surprise.

Nicolas Sebrecht

[Prev in Thread] Current Thread [Next in Thread]