Re: [PATCH] fix socket.ssl() deprecation with respect to older versions

[John Goerzen <jgoerzen@xxxxxxxxxxxx>]

Christoph Höger wrote:
> Am Montag, den 29.06.2009, 15:59 -0500 schrieb John Goerzen:
>> Christoph Höger wrote:
>>> Hi John,
>>> what about this one? 
>>> Are there any problems with that patch?
>> Thanks for the ping; I had missed it.
>>
>> It doesn't apply though; it maybe isn't against the head of master in my
>> git repo?  It's wanting to remove lines that aren't there anymore anyhow.
> Ah, my fault. Created it against my 6.0.3 version. It looks like you
> removed that stuff completely from your sources. Only call to
> socket.ssl() seems to be in imaplib2.py.
> I have a patch for that, but do you want to keep a fork of imaplib2 ?
> 
>> You might note that 5fe379f66d2265f6ddd30f85384daf318f303be9 goes a
>> slight way towards what you're doing.
> 
> Well, no. That one still uses socket.ssl, which is deprecated since 2.6
> 
> Shall I send you the imaplib2 patch?

I would prefer you send that to the imaplib2 maintainers.  Once they
accept it, I will simply pull in an updated imaplib2 into my source tree.

I got into maintaining diffs against imaplib.py awhile back, and it was
not very sustainable.

-- John

> 
> 
> -- Attached file included as plaintext by Ecartis --
> -- File: signature.asc
> -- Desc: Dies ist ein digital signierter Nachrichtenteil
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> 
> iEYEABECAAYFAkpJMmkACgkQhMBO4cVSGS/VqQCgn4BDtDcsxN+nSAlfIcPEbo2p
> BFAAn34y8d4I0LygFyiv5ius33RG71+j
> =0LkL
> -----END PGP SIGNATURE-----
> 
> 
> 
>