Complete.Org: Mailing Lists: Archives: offlineimap: January 2009:
Re: [PATCH] Fix md5 import error

Re: [PATCH] Fix md5 import error

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Loui Chang <>
Cc: Michael Witten <mfwitten@xxxxxxx>, offlineimap@xxxxxxxxxxxx
Subject: Re: [PATCH] Fix md5 import error
From: John Goerzen <jgoerzen@xxxxxxxxxxxx>
Date: Thu, 08 Jan 2009 10:07:08 -0600

Loui Chang wrote:
> On Thu, Jan 08, 2009 at 09:18:00AM -0600, Michael Witten wrote:
>>  On 31 Dec 2008, at 10:26 AM, Loui Chang wrote:
>>>> Paul Hinze <paul.t.hinze@xxxxxxxxx> on 2008-12-22 at 19:16:
>>>>> I did a bit of debugging and asking around in #python and it turns out
>>>>> that because uses a conditional import of md5 from either
>>>>> hashlib or the md5 module, the call is not always correct.
>>>>> The attached patch should fix this problem.
>>> Oh darn. Good thing you caught that.
>>> Things seem to work fine with hashlib and this patch now.
>>> I actually tested it this time.
>>  I have pulled from the public git repo:
>>      git://
>>  and I don't seem to have gotten the new patch; I still
>>  get the runtime error that Paul fixed.
> John Goerzen hasn't pushed it yet. Maybe he's out on vacation hah.

I was, and now have a serious case of inbox overload.  Will try to get
to this today.

[Prev in Thread] Current Thread [Next in Thread]