Complete.Org: Mailing Lists: Archives: offlineimap: July 2003:
Re: A new UI: Noninteractive.Summary [patch]
Home

Re: A new UI: Noninteractive.Summary [patch]

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Akkana Peck <akkana@xxxxxxxxxxxxxx>
Cc: offlineimap@xxxxxxxxxxxx
Subject: Re: A new UI: Noninteractive.Summary [patch]
From: John Goerzen <jgoerzen@xxxxxxxxxxxx>
Date: Mon, 7 Jul 2003 08:22:45 -0500

Excellent!  It is great to see some code contributed.  I will get this
applied quickly.  A couple of comments follow:

> So anyway, I derived a new UI, called Noninteractive.Summary.  It didn't
> seem like there was any way to collect the actual messages as python
> objects -- by the time they get to the UI they've already been turned

You can, by overriding the methods in UIBase.  For instance, instead of
searching the string for "Finished processing account", you could do this
inside your UI class:

    def acctdone(s, accountname):
        # Print summaries or whatever here
        Basic.acctdone(s, accountname)

Here you use Basic rather than UIBase in the call to acctdone since Basic is
the class you're inheriting from.

> 7c7,8
> < #    the Free Software Foundation; version 2 of the License.
> ---
> > #    the Free Software Foundation; either version 2 of the License, or
> > #    (at your option) any later version.

Patches to license text will almost always be rejected.  However, in this
case, you've patched it to what it already is, so there's no problem :-)

(Can't have somebody sneaking in a patch to re-license it under an MS EULA
<g>)

-- John


[Prev in Thread] Current Thread [Next in Thread]