[Freeciv] Re: [Freeciv-Dev] Re: Profiling Civserver again

[Jason Dorje Short <jshort@xxxxxxxxxxxxx>]

Jarda Benkovsky wrote:
> Jason Dorje Short wrote:

> Just to slow you down a bit - do not overoptimize such things - maybe
> freeciv will have more complicated map topology one day and it would be
> a pity to add all that now unnecessary code back.
> 
> OTOH, it may be completely useless in that case too, so maybe a function
> would be better :)

Actually, I was thinking of the *_iterate macros; they should be
optimized for the current setup.  However, when I looked at them it
appears as though they pretty much are - most of them don't use
normalize_map_pos.

But, these macros aren't used as much as they could be - and for good
reason.  It's dangerous to just substitute them in rampantly, because
they don't behave the same way as the current "for" loops.  With a
gradual transition to them things should improve.

jason