[FreeCiv-Java] Re: 3 suggestions

["Brian Duff" <Brian.Duff@xxxxxxxxxx>]

Hi Luke,

Thanks for the suggestions!

The map view component in freerails looks very interesting. I'm working on
this right now, and trying to keep it kind of similar to the C version of
freeciv (well in terms of the way it works, rather than the emmm...design).
But your code looks like it will come in very useful for helping out with
the bits I'm finding tricky and which the C code doesn't help much with (in
particular, scrolling, which I'm a bit scared about in general, to be
honest). So, thanks for that :)

About the datadir: The datafiles we use are the same as the ones that come
with the C version of Freeciv. One of the useful things is that you can drop
in new tilesets and rules very easily. So the datadir property will probably
stick around. But you're right, there's no reason not to load the "standard"
data files from the classpath, and just allow them to be overridden by the
datadir property. I'll try to get round to this at some point (unless
someone else feels like doing it :) )

Good catch about the assert thing... The three broken files were kind of
old, and weren't using the common (warningless) Assert code. Anyway, I've
checked in a fix now, and a fix for the deprecation warning in CivMap.java
under 1.4.

Thanks,

Brian



-----Original Message-----
From: freeciv-java-bounce@xxxxxxxxxxx
[mailto:freeciv-java-bounce@xxxxxxxxxxx]On Behalf Of Luke Lindsay
Sent: 31 October 2001 20:54
To: freeciv-java@xxxxxxxxxxx
Subject: [FreeCiv-Java] 3 suggestions


I recently downloaded a freeciv java client.  I have a few suggestions that
might be useful.

(1)  For the map view, it might be worth you looking at the map view
component I wrote for the project I work on - the java client for freerails.
The projects still in the early stages of development, but there is a
working map view component.  See:
http://sourceforge.net/projects/freerails/
(Let me know if you would like more details.)

The next two are not really that important, but should be easy to fix.

(2)  I find having to set the datadir a bit of a pain.  Have you considered
using className.getResource() instead, which allows you to load resources
relative to the classpath among other things?

(3)  In jdk 1.4 'assert' is a reserve word.  Maybe it would be a good idea
to replace 'assert(' with 'assertThat(' to avoid a lot of warning messages
when compiling under 1.4.

regards

Luke