[FreeCiv-Java] Re: the java files

[John Goerzen <jgoerzen@xxxxxxxxxxxx>]

Hi,

I took a look at the code.  Looks good.  One minor nit:

The FreeCiv revision and version compatibility string really should
not be in freeciv.Client.

I'll go ahead and integrate this with my existing codebase.

I understand this was a unique circumstance, so what I'm going to say
below applies to future stuff only.

When there's a patch, please send it to freeciv-java@xxxxxxxxxxx.
Please send a diff only.  This can be generated like this.

1. Download the pristine latest sources from software.complete.org
2. Unpack.  Starting with 0.005, the directory unpacked in the tar,gz
   will include the version number of the release.
3. Make a copy of this directory (cp -r will do nicely).  Make your
   actual changes in your new directory.

Then, make the diff like this:

(be in the parent of both)

diff -d -u -r civclient-java-0.005 civclient-java-0.005.new > difffile

Then mail difffile to freeciv-java@xxxxxxxxxxx.

This way, we have a permanent record of the diffs people supply, and
it makes it easy to integrate them into the source.

I am still working on CVS.  I am a little leery of pserver due to
security risks and how my CVSROOT is currently set up.  The code
eventually does go into my own CVS area.  I'll try to get a good thing 
eventually, but for the moment the snapshot tar.gz's will have to do.

Esben Haabendal Soerensen <ehs@xxxxxxxxxxxxxx> writes:

> Hi John
> 
> I have put a tar-gz archive on
>  http://sunsite.auc.dk/~bart/freeciv/javaclient.tar.gz
> 
> The state of these files are:  I just wrote these to try out
> how my ideas would look in code.  I have not even bothered
> compiling them because I wanted to hear what you thought
> of my ideas before persuing them.
> 
> But have a look at it please ;-)
> 
> I have not been part of a distributed freesource project before,
> but shouldn't we change the header text sometime before actually
> releasing some code ?
> Not something we need to think of right now though :-)
> 
> -- 
> /Esben  (bart@xxxxxxxxxxxxxx)
> 
> You want it in one line?  Does it have to fit in 80 columns?   :-)
>              -- Larry Wall in <7349@xxxxxxxxxxxxxxxxxxxxxxx>
> 

-- 
John Goerzen   Linux, Unix consulting & programming   jgoerzen@xxxxxxxxxxxx |
Developer, Debian GNU/Linux (Free powerful OS upgrade)       www.debian.org |
----------------------------------------------------------------------------+
Visit the Air Capital Linux Users Group on the web at http://www.aclug.org