[freeciv-i18n] i18n improvement in connecthand.c
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
on Sun Jul 13 there was some new code added into server/connecthand.c:
/* remind the connection who he is */
if (!pconn->player) {
my_snprintf(buf, sizeof(buf), _("no player"));
} else if (strcmp(pconn->player->name, ANON_PLAYER_NAME) == 0) {
my_snprintf(buf, sizeof(buf), _("an anonymous player"));
} else {
my_snprintf(buf, sizeof(buf), "'%s'", pconn->player->name);
}
notify_conn(dest, _("You are logged in as '%s' connected to %s."),
pconn->username, buf);
IMO It's just another example of bad i18n. When you speak polish you
don't say something like 'there is is _NO_ player' but you have to use
different construction, and it cannot be put into printf format so easy
I think we should use attached patch
--
mateusz
-- Binary/unsupported file stripped by Ecartis --
-- Type: text/x-diff
|
|