[Freeciv-Dev] Re: (PR#19755) Renaming CMA -> City Governor not complete

["Jason Dorje Short" <jdorje@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=19755 >

Guest wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=19755 >
> 
> Hi,
> 
> Here's the patch;  internally it's still called CMA such as
> IDM_HELP_CMA but I didn't touch them.  Only messages are changed.

The patch is a good start but there's some problems.  In menus the _ 
underline usually means the shortcut (accelerator) key for that entry. 
but for the GTK2 help menu you have changed the accelerator from M to G. 
  This is a problem because G is already used.

-  { "/" N_("Help") "/" N_("Citizen _Management"), 
NULL,
+  { "/" N_("Help") "/" N_("Citizen _Governor"), 
NULL,

For other clients besides the gtk2 one it's worse since I can't even 
tell if the changes will break anything.

-jason