Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2006:
[Freeciv-Dev] (PR#19204) superfluous call to set_client_page() in clinet
Home

[Freeciv-Dev] (PR#19204) superfluous call to set_client_page() in clinet

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] (PR#19204) superfluous call to set_client_page() in clinet.c?
From: "Christian Prochaska" <cp.ml.freeciv.dev@xxxxxxxxxxxxxx>
Date: Thu, 3 Aug 2006 21:55:13 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=19204 >

in clinet.c line 120:

if (!with_ggz) {
  set_client_page(in_ggz ? PAGE_GGZ : PAGE_MAIN);
}

reports_force_thaw();

set_client_state(CLIENT_PRE_GAME_STATE);

-----

the set_client_state() function calls set_client_page(), too, so the
call in clinet.c is not really necessary, is it?
Index: clinet.c
===================================================================
--- clinet.c    (Revision 12228)
+++ clinet.c    (Arbeitskopie)
@@ -117,9 +117,6 @@
   remove_net_input();
   popdown_races_dialog(); 
   close_connection_dialog();
-  if (!with_ggz) {
-    set_client_page(in_ggz ? PAGE_GGZ : PAGE_MAIN);
-  }
 
   reports_force_thaw();
   

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#19204) superfluous call to set_client_page() in clinet.c?, Christian Prochaska <=