[Freeciv-Dev] (PR#18725) [Patch] Don't use city warmap for unit

["Marko Lindqvist" <cazfi74@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=18725 >


  Warmaps generated for units and cities are substantially different. 
Currently city warmap is sometimes used for unit as cached value. I 
don't think saved CPU cycles are worth the inaccuracy. This is not bad 
only for unit, but it seems that city warmap itself is compromise 
between (defensive) city warmap and (offensive) unit warmap.
  With attached patch city warmap is never used for unit.


  - ML

diff -Nurd -X.diff_ignore freeciv/server/gotohand.c freeciv/server/gotohand.c
--- freeciv/server/gotohand.c   2006-07-19 22:10:52.012149800 +0300
+++ freeciv/server/gotohand.c   2006-07-19 23:26:45.699649800 +0300
@@ -393,14 +393,6 @@
 
   if (punit) {
     /* 
-     * Checking for an existing warmap. If the previous warmap was for
-     * a city and our unit is in that city, use city's warmap.
-     */
-    if (pcity && pcity == warmap.warcity) {
-      return;
-    }
-
-    /* 
      * If the previous warmap was for the same unit and it's still
      * correct (warmap.(sea)cost[x][y] == 0), reuse it.
      */