[Freeciv-Dev] (PR#15729) player ordering changes bizarrely when you observe AI players

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15729 >

1.  Run ./civ -a & ./ser

2.  /set aifill 5

3.  /list

        jdorje (user jdorje, Human, team Team 1, not ready)
                  1 connection:
          jdorje from localhost.localdomain (command access level hack)
        AI1 (user Unassigned, AI, difficulty level easy, team Team 2)
        AI2 (user Unassigned, AI, difficulty level easy, team Team 3)
        AI3 (user Unassigned, AI, difficulty level easy, team Team 4)
        AI4 (user Unassigned, AI, difficulty level easy, team Team 5)

4.  /observe AI4

        jdorje: '/observe AI4'
        jdorje detaching from jdorje
        2: Removing player jdorje.
        2: AI5 has been added as easy level AI-controlled player.

5.  /list

        AI1 (user Unassigned, AI, difficulty level easy, team Team 2)
        AI2 (user Unassigned, AI, difficulty level easy, team Team 3)
        AI3 (user Unassigned, AI, difficulty level easy, team Team 4)
        AI4 (user Unassigned, AI, difficulty level easy, team Team 5)
                1 connection:
          jdorje from localhost.localdomain (command access level hack),        
 
bufsize=44kb (observer mode)
        AI5 (user Unassigned, AI, difficulty level easy, team Team 1)

6.  /observe AI5

        jdorje: '/observe AI5'
        jdorje detaching from AI4
        2: Removing player AI4.
        2: AI4 has been added as easy level AI-controlled player.

7.  /list

        AI1 (user Unassigned, AI, difficulty level easy, team Team 2)
        AI2 (user Unassigned, AI, difficulty level easy, team Team 3)
        AI3 (user Unassigned, AI, difficulty level easy, team Team 4)
        AI5 (user Unassigned, AI, difficulty level easy, team Team 1)
                1 connection:
          jdorje from localhost.localdomain (command access level hack),        
 
bufsize=44kb (observer mode)
        AI4 (user Unassigned, AI, difficulty level easy, team Team 5)

Looking at the full list of messages it's clear that AI4 is deleted and 
then recreated when you do /obs AI5.  But from the user's point of view 
(and this shows in the GTK conn dialog which doesn't show the "name", 
making it even more confusing) the two players have swapped places.

The apparent fix is to not delete the AI player in this case.

-jason