[Freeciv-Dev] (PR#15582) airlifting bug

["Jaroslav Libák" <jarol1@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15582 >

Hi
While programing a new warclient I stumbled upon a weird condition in unit.c > 
unit_can_airlift_to(); which causes a bug
when server allows airlifting into cities without airports as long as the 
source city has an airport.

The code is 
if (!punit->tile->city->airlift || !punit->tile->city->airlift) {
return FALSE;
}

and should be 
if (!punit->tile->city->airlift || !pcity->airlift) {
return FALSE;
}

However lots of players use airlifting into cities with airports close to enemy 
to speed up unit movements across big maps. Allowing only 1 airlift into city 
with an airport would slow down the game during attacking considerably so I 
propose another modification:
unittools.c > do_airline(struct unit *punit, struct city *city2)

remove the line  city2->airlift = FALSE; 
to allow multiple airlifts into single city with an airport

Jaro