[Freeciv-Dev] (PR#15521) freeciv doesn't compile with --enable-client=sdl

["Martin.Gerdes@xxxxxxxxxxxxx" <Martin.Gerdes@xxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15521 >

Hello!
A few days ago I successfully compiled freeciv using the commands:
./autogen.sh --enable-client=sdl
make

Now I tried to recompile after including the patches by Christian Prochaska. 
Didn't work. So I tried recompiling using the exact same source (unpatched) I 
used the first time (freeciv CVS snapshot from 31.1.06). Still doesn't work! I 
get:

if gcc -DHAVE_CONFIG_H -I. -I. -I../..  -I. -I./.. -I./../include 
-I../../utility -I../../common -I../../common/aicore -I../../intl -I./../agents 
-I/usr/include/SDL -D_REENTRANT -I/usr/include/freetype2   -g -O2 -Wall 
-Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations 
-I/usr/include/SDL -D_REENTRANT -MT graphics.o -MD -MP -MF ".deps/graphics.Tpo" 
-c -o graphics.o graphics.c; \
then mv -f ".deps/graphics.Tpo" ".deps/graphics.Po"; else rm -f 
".deps/graphics.Tpo"; exit 1; fi
In file included from /usr/include/SDL/SDL_syswm.h:56,
                 from graphics.c:31:
/usr/include/X11/Xlib.h:3578: error: syntax error before '_X_SENTINEL'
...     [error line repeated for lines: 3583, 3596, 3609, 3614, 3846, 3850, 
3862, 3890, 3894, 3934]
In file included from graphics.c:45:
themespec.h:53: warning: type qualifiers ignored on function return type

Then make aborts. The only thing I remember changing on my system (debian 
unstable) is upgrading gimp with all its dependencies. Might it be that you are 
missing a configure check or are relying on old library behavior?
I admit I didn't look into Xlib.h to see whether it could be their mistake.
All I know is that Xlib.h is contained in package libx11-dev, which is of 
version 6.9.0.dfsg.1-4 on my computer, which is current. And since libx11-6 is 
a dependency of gimp, it is very likely that this package got updated. I don't 
know what the old version was, though...

gcc version is 4.0.3

Hope this helps,

Icekiss