[Freeciv-Dev] Re: (PR#15250) City outline bug

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15250 >

Daniel Markstedt wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=15250 >
> 
> See screenshot. Reproduce by loading attached savegame and found a city
> at that spot.

Because the tiles are unknown you don't know that they belong to the 
enemy.  Since the adjacent tiles are known to belong to the enemy, the 
outline gets drawn.

However fixing this is tricky.  The obvious solution is to treat unknown 
tiles as not belonging to the city.  But then things will get drawn 
wrongly sometimes when those tiles *should* be part of the outline.

Interestingly in isotrident the outline graphics are drawn *underneath* 
the unknown...which has the effect of hiding the problem in most cases. 
  Even more interestingly hex draws the outlines above the unknown even 
though  hex is handled pretty much identically to iso.  Could be another 
bug here somewhere.

-jason

Index: client/tilespec.c
===================================================================
--- client/tilespec.c   (revision 11513)
+++ client/tilespec.c   (working copy)
@@ -3757,7 +3757,7 @@
       }
       worked[i] = FALSE;
 
-      city[i] = (tile
+      city[i] = (tile && known[i]
                 && (!powner || !game.player_ptr || powner == game.player_ptr)
                 && (!game.player_ptr
                     || player_in_city_radius(game.player_ptr, tile)));